Open
Conversation
Owner
|
oh nice, i guess I missed the notification on this one, I'll take a look at it when I have some time and then merge it in. Thanks! I could see needing to remove from a running client.. say you create then erase an aux bus channel or something? |
Author
|
I also realize now that this doesn't update either the swig interface or the blocking API. I'm going to put some more thought into how it could be made to work with running clients in the next few days because it became a bit annoying having to reconnect all ports after removing a few. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client cannot be running when this is done, because then we may erase from the middle of
m{Input,Output}PortswhilejackToClassAudioCallbackis getting the ports. There's probably a way to defer erasing the port so this can be worked around, but does anyone need to remove ports from a running client anyways?